Merged
Conversation
Simplify FamiliesAnnually2025 lookup to always return "families-2025". Remove PreProcessFamiliesPreMigrationPlan deployment safeguard method and its call sites. Remove unused IFeatureService constructor dependency.
…rOrganizationAsync Remove milestone3 variable and parameter from AlignOrganizationSubscriptionConcernsAsync. Simplify guard clause to only check plan type.
Remove IFeatureService from test setup. Delete tests for flag-disabled safeguard behavior. Clean up remaining test names.
Remove all feature flag mock setup lines for PM26462_Milestone_3. Delete test methods that verified flag-disabled behavior.
Contributor
|
New Issues (121)Checkmarx found the following issues in this Pull Request
|
connerbw
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7354 +/- ##
=======================================
Coverage 58.71% 58.71%
=======================================
Files 2069 2069
Lines 91207 91207
Branches 8123 8123
=======================================
+ Hits 53551 53552 +1
+ Misses 35742 35741 -1
Partials 1914 1914 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Base automatically changed from
billing/PM-31909/remove-m3-flagged-logic-server
to
main
April 14, 2026 19:32
…ve-m3-flag-definition-server # Conflicts: # src/Core/Constants.cs # test/Core.Test/Billing/Pricing/PricingClientTests.cs
amorask-bitwarden
approved these changes
Apr 14, 2026
|
ike-kottlowski
pushed a commit
that referenced
this pull request
Apr 17, 2026
* Remove pm-26462-milestone-3 flag from PricingClient Simplify FamiliesAnnually2025 lookup to always return "families-2025". Remove PreProcessFamiliesPreMigrationPlan deployment safeguard method and its call sites. Remove unused IFeatureService constructor dependency. * Remove pm-26462-milestone-3 flag from UpcomingInvoiceHandler.HandleForOrganizationAsync Remove milestone3 variable and parameter from AlignOrganizationSubscriptionConcernsAsync. Simplify guard clause to only check plan type. * Update PricingClientTests after pm-26462-milestone-3 removal Remove IFeatureService from test setup. Delete tests for flag-disabled safeguard behavior. Clean up remaining test names. * Update UpcomingInvoiceHandlerTests after pm-26462-milestone-3 removal Remove all feature flag mock setup lines for PM26462_Milestone_3. Delete test methods that verified flag-disabled behavior. * Remove PM26462_Milestone_3 flag definition from FeatureFlagKeys
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-31911
https://bitwarden.atlassian.net/browse/PM-31893
📔 Objective
Remove the
PM26462_Milestone_3constant fromFeatureFlagKeysinConstants.cs. All flagged logic was removed in the parent PR.